New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MediaBrowser as a supported Server Selection #282
Comments
This issue depends on #281 |
Issue #281 has been completed. The app now uses Dagger for dependency injection. Working on fixing some injection points up. Will need to install the latest MediaBrowser and the Java client for it. |
Official client code for this support is available at the following project. https://github.com/MediaBrowser/Emby.ApiClient.Java Unfortunately this isn't deployed to JCenter so will need to fork this and create a version that I can import into the project. I'd rather not include the binaries in a lib directory but may have to do it just to get things going. |
started work on this, and it looks like I will need to implement a similar Server discovery that we use for Plex. The problem with the IServerLocator and ServerLocator implementations from the Emby Media browser Java code, is that it doesn't emit the items as it finds them. Instead it loops through a time out period, and after the time out period it sends out the notification of all the servers that were discovered. Serenity needs a slight modification to this code so that there is an Implementation that during the time out period, it will emit each of the servers it finds instead of adding them to an array list. It should post an event for the serves, and then Serenity will listen for the event and add the discovered server to the list of available servers. The above code can be used as a basis, and if we implement a different Callback interface we can generalize it.
|
This is now implemented. A new Server Selection screen will present available servers. This is shown once, and will take the user either the the Main screen or a User Login screen. I've ended up discarding the emby's official API and writing one myself. It was just easier to deal with and we don't need everything that Emby provides. |
In the Discovered Servers, Media Browser should be an option. This means implementing server discovery for the Media Browser just as we do with Plex, and also implementing a Communication layer to build up the necessary VideoContentInfo objects. This does depend on Dagger being implemented in the application at least at the communication level with the server.
Information on the communication layer for MediaBrowser is here.
https://github.com/MediaBrowser/MediaBrowser.ApiClient.Java
The text was updated successfully, but these errors were encountered: