New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use writer to avoid string copy #3

Closed

BugenZhao wants to merge 1 commit into NingLin-P:br-text from ibugen:br-text

BugenZhao commented Aug 17, 2021

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tidb-ansible:
Need to cherry-pick to the release branch

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression
- Consumes more CPU
- Consumes more MEM
Breaking backward compatibility

Release note

Please add a release note.
If you don't think this PR needs a release note then fill it with None.


          use writer to avoid string copy

e007a81

BugenZhao force-pushed the br-text branch from c38c2c8 to e007a81 Compare

August 17, 2021 08:43

BugenZhao closed this

Author

BugenZhao commented Aug 17, 2021

This will (unexpectedly) lead to performance decrease, thus close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment