Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some work on date/time and network converters #2

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Some work on date/time and network converters #2

merged 3 commits into from
Jul 3, 2023

Conversation

roji
Copy link
Collaborator

@roji roji commented Jun 29, 2023

No description provided.

@roji roji requested a review from NinoFloris June 29, 2023 14:14
NinoFloris
NinoFloris approved these changes Jun 29, 2023
View reviewed changes
Copy link
Owner

@NinoFloris NinoFloris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, depending on whether you still want to add NpgsqlInet you might want to exclude PgInet

@NinoFloris NinoFloris force-pushed the handler-rework branch 7 times, most recently from d22f63a to b4dba80 Compare June 30, 2023 22:11
@roji roji force-pushed the SomeConverters branch 2 times, most recently from 5f3ecbd to 79939f8 Compare July 2, 2023 18:42
@roji
Copy link
Collaborator Author

roji commented Jul 2, 2023

@NinoFloris rebased and redid the network types as per npgsql#5136 (I tried not to introduce creep but implementing the existing setup started to get really annoying, and as we want to change anyway...).

In any case, take a look at the last commit; two tests still fail, you may want to take a look at some point. After this I'll go on to work on other various converters.

@NinoFloris NinoFloris merged commit cd999fc into NinoFloris:handler-rework Jul 3, 2023
1 of 17 checks passed
@roji roji deleted the SomeConverters branch July 3, 2023 18:45
@roji roji mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NinoFloris NinoFloris NinoFloris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@roji @NinoFloris