Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation Events #51

Closed
2 tasks done
Tracked by #33
Rydsund opened this issue Sep 22, 2021 · 0 comments
Closed
2 tasks done
Tracked by #33

Animation Events #51

Rydsund opened this issue Sep 22, 2021 · 0 comments
Labels
graphics
Projects
Kanvas (Pre Production)

Comments

@Rydsund
Copy link
Collaborator

Rydsund commented Sep 22, 2021 •
edited
Loading

Definition of done

  • Use animation events to notify the trail effect.
  • Trail effects start when either feet touch ground.

Conclusion: Animation events work and are not to complicated to add. In relation to ice trails it is simply easier to use colliders on each feet as they work for all animations.

Added findings: Many of the basic animations are good enough, a lot of them have root motion which needs to be disabled individually for each animation in Maya.
@Rydsund Rydsund created this issue from a note in Kanvas (Pre Production) (Ungroomed) Sep 22, 2021
@Rydsund Rydsund moved this from Ungroomed to To do in Kanvas (Pre Production) Sep 22, 2021
@Rydsund Rydsund self-assigned this Sep 22, 2021
@DannyDarwiche DannyDarwiche mentioned this issue Sep 22, 2021
Open
14 tasks
@Rydsund Rydsund changed the title Pattern recognition USE OR DELETE Sep 30, 2021
@Rydsund Rydsund removed their assignment Sep 30, 2021
@Nirase Nirase moved this from To do to Ungroomed in Kanvas (Pre Production) Oct 2, 2021
@Rydsund Rydsund changed the title USE OR DELETE Animation Events Oct 3, 2021
@Rydsund Rydsund moved this from Ungroomed to To do in Kanvas (Pre Production) Oct 3, 2021
@Nirase Nirase added the graphics label Oct 3, 2021
Rydsund added a commit that referenced this issue Oct 3, 2021
@Rydsund
Add ice trail fixes
e5cf6c6 
Some values got lost in rebase, added them again.
WIP #51
Rydsund added a commit that referenced this issue Oct 3, 2021
@Rydsund
Add movement controls
27b967d 
Adding checkpoint to make sure all changes are pushed.
WIP #51
@Nirase Nirase moved this from To do to In progress in Kanvas (Pre Production) Oct 4, 2021
@Nirase Nirase moved this from In progress to To do in Kanvas (Pre Production) Oct 4, 2021
Rydsund added a commit that referenced this issue Oct 4, 2021
@Rydsund
Add trails
a71d3f9 
Added ice trails to controller.
WIP #51
Rydsund added a commit that referenced this issue Oct 4, 2021
@Rydsund
Changed the transform of ice trails.
f93e7e9 
Ice trails now properly trace feet. during animation. However the trails persist even when one foot is above ground.
WIP #51
@Rydsund Rydsund moved this from To do to In progress in Kanvas (Pre Production) Oct 5, 2021
Rydsund added a commit that referenced this issue Oct 5, 2021
@Rydsund
Add color gradient possibilities
59c0237 
Added a way to change the color of the ice trails via gradient. Could possibly be expanded upon to provide masking for when one foot is in the air.
Fixes #51
Rydsund added a commit that referenced this issue Oct 5, 2021
@Rydsund
Add ice trail fixes
c714d4c 
Some values got lost in rebase, added them again.
WIP #51
Rydsund added a commit that referenced this issue Oct 5, 2021
@Rydsund
Add movement controls
b765caa 
Adding checkpoint to make sure all changes are pushed.
WIP #51
Rydsund added a commit that referenced this issue Oct 5, 2021
@Rydsund
Add trails
63fabc6 
Added ice trails to controller.
WIP #51
Rydsund added a commit that referenced this issue Oct 5, 2021
@Rydsund
Changed the transform of ice trails.
f396f2a 
Ice trails now properly trace feet. during animation. However the trails persist even when one foot is above ground.
WIP #51
@Rydsund Rydsund closed this as completed in bf5c12c Oct 5, 2021
Kanvas (Pre Production) automation moved this from In progress to Done Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
graphics
Projects
Kanvas (Pre Production)
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nirase @Rydsund