-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for negative values in process_nst_mbll.m is done on NIRS and AUX data #142
Comments
Nice catch ! Fixed in #143. Thanks for your contribution |
Thanks for the report. I think I should also fix the detect bad channel process as it is automatically marking auxiliary channel as bad. IMU is accelerometer data? You don't have trouble with the acquisition frequency as Brainstorm require the auxiliary measurement to be sampled at the same frequency as the nirs signal ?
Oh that's a nice idea. I think you might have contacted Zhengchen Cai who is busy finishing is phd right now. Personally, I started my PhD under the supervision of Christophe Grova in September, and am currently the main maintainer of Nirstorm and I would really appreciate to be part of this project. My email is edouard.delaire@concordia.ca
Well, as you demonstrated, increasing the visibility of the toolbox is always a good thing as the more people use nistorm, the more likely is is that we will find new bug, or develop new features making, at the end, our research better quality :) Best regards,
|
nirstorm/bst_plugin/mbll/process_nst_mbll.m
Lines 101 to 105 in d9194c0
The check for negative values is done on all data, including AUX. This is an issue when AUX channels contain negative values. Check should probably occur after NIRS data is separated from AUX data:
nirstorm/bst_plugin/mbll/process_nst_mbll.m
Lines 110 to 112 in d9194c0
The text was updated successfully, but these errors were encountered: