Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate plans search result template #698

Closed
tkdchen opened this issue Jun 26, 2020 · 1 comment · Fixed by #748
Closed

Remove duplicate plans search result template #698

tkdchen opened this issue Jun 26, 2020 · 1 comment · Fixed by #748
Assignees
@tkdchen
Labels
cleanup refactor technical debt
Milestone
4.8

Comments

@tkdchen
Copy link
Member

tkdchen commented Jun 26, 2020 •
edited

The duplication exists in plans search result page and the advanced search result page. They have:

  • same action buttons and the same logic to enable/disable part of the buttons
  • same columns in the table displaying plans.

By the way, remove the Show NNN entries from plans search result.
@tkdchen tkdchen added this to the 4.8 milestone Jun 26, 2020
@tkdchen tkdchen mentioned this issue Aug 14, 2020
Closed
4 tasks
@tkdchen
Copy link
Member Author

tkdchen commented Aug 14, 2020

A major problem needs to be fixed firstly. That is, the plans search result is using DataTable plugin to control the pagination and requesting plans in other pages, but advanced search result is controlled by Django pagination manually. This difference causes the search result templates are rewritten in different way and difficult to unify them into one.

@tkdchen tkdchen mentioned this issue Aug 17, 2020
Closed
3 tasks
@tkdchen tkdchen self-assigned this Aug 22, 2020
tkdchen added a commit to tkdchen/Nitrate that referenced this issue Aug 22, 2020
@tkdchen
Remove duplicate plans search result template (Nitrate#698)
02d3b60 
Signed-off-by: Chenxiong Qi <qcxhome@gmail.com>
@tkdchen tkdchen linked a pull request Aug 22, 2020 that will close this issue
Remove duplicate plans search result template (#698) #748
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkdchen tkdchen

Labels
cleanup refactor technical debt
Projects
None yet
Milestone
4.8
Development

Successfully merging a pull request may close this issue.

Remove duplicate plans search result template (#698) tkdchen/Nitrate
1 participant
@tkdchen