Result values in failure messages #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, I will review the changes and reply with approval or feedback here shortly! |
KyleMcMaster
approved these changes
Mar 31, 2023
|
I will get a release of these changes out soon! Thanks for the contribution! |
|
@Yaevh This is now available in version 2.0.0-prerelease-10-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When asserting for success and the Result actually fails, the error is not specified in test output, only "Expected Result to be successful but it failed". This complicates the testing process, as for each failing test the user has to analyze the output or re-run the test under the debugger to determine the cause of failure.
In this PR, error and success values are included in test output if an assertion fails. Also the messages themselves are slightly improved to make them more readable.
For example:
Expected Result to be successful but it failed->Expected myAwesomeResult to succeed, but it failed with error "some error"Expected Result to be failure but it succeeded->Expected myAwesomeResult to fail, but it succeeded with value "foo"