Upstream devices

[paulmenzel]

It’d be great, if you upstreamed the devices to the coreboot project.

[daringer]

I did not have the impression that these qualify as separate "devices", as all of them are either re-branded from existing upstream devices (nitropc) or from the dasharo repo (nitrowall/nitrowall pro). In detail these are more or less pre-configured with the biggest change being the PL1+2 for one of them inside the devicetree.cb.

Am I judging this wrong? Would this qualify for new devices on coreboot upstream?

[paulmenzel]

In detail these are more or less pre-configured with the biggest change being the PL1+2 for one of them inside the devicetree.cb.

Can you elaborate please?

Am I judging this wrong? Would this qualify for new devices on coreboot upstream?

At least it would qualify as a variant. If it’s just rebranding, then it’d be great, if the name NitroPC would show up in the documentation and Kconfig description. The goal should be, that the firmware for a device can be easily built from the upstream sources with the upstream build system.