Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase user password buffer in IsAESSupported command #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Increase user password buffer in IsAESSupported command #158

wants to merge 1 commit into from

Commits on May 27, 2019

  1. Increase user password buffer in IsAESSupported command 

    The IsAESSupported command struct has a 20 byte buffer size for storing
the user password. That is in contrast to, say, the EnablePasswordSafe
struct which uses a 30 byte buffer. Such a smaller buffer can cause
string length errors to be emitted for a legitimate user PIN as has been
found as part of the investigation for d-e-s-o/nitrocli#85. That is, the
nitrokey allows for setting a user PIN of 21 characters. Retrieving an
OTP using such a PIN works fine, whereas inquiring the PWS status does
not, as it first tries to cram the supplied password into 20 characters,
which fails.
This change increases the buffer size in the IsAESSupported command
struct to 30 bytes.
    @d-e-s-o
    d-e-s-o committed May 27, 2019
    Configuration menu
    Copy the full SHA
    9072748 View commit details
    Browse the repository at this point in the history