Enable SE050 by default #471
Merged
+139
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
space-migrate-enable-se050
branch
3 times, most recently
from
31854c4
to
ea1e181
Compare
Insignifcant changes
|
sosthene-nitrokey
force-pushed
the
space-migrate-enable-se050
branch
from
ea1e181
to
d4ab5d4
Compare
components/apps/src/lib.rs
Outdated
Comment on lines
161
to
168
| impl Default for OpcardConfig { | ||
| fn default() -> Self { | ||
| Self { | ||
| #[cfg(feature = "se050")] | ||
| use_se050_backend: true, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
AFAIS this silently changes the configuration when upgrading from the test release with se050 disabled. Do we really want that?
There was a problem hiding this comment.
It also automatically enables the se050 backend when upgrading from stable with the default config. My idea last week was to use two separate config states:
- a default state, i. e.
Default::default, that is used when an option is not set explicitly - an init state that is set during provisioning or after a factory reset
Ideally, the init state would be the default state for most options, but here we need to make a distinction.
There was a problem hiding this comment.
There's also the problem that after a factory reset the config is not saved again. I need to expose a way to do that with the admin-app.
So many edge cases.
There was a problem hiding this comment.
Should be fixed now.
sosthene-nitrokey
force-pushed
the
space-migrate-enable-se050
branch
3 times, most recently
from
1b49d07
to
02c8fbb
Compare
sosthene-nitrokey
force-pushed
the
space-migrate-enable-se050
branch
from
02c8fbb
to
da2ac3a
Compare
daringer
approved these changes
Apr 12, 2024
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: