Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send 20 null bytes as a secret on OTP edit #138

Closed
szszszsz opened this issue Sep 12, 2016 · 0 comments · Fixed by #151
Closed

Send 20 null bytes as a secret on OTP edit #138

szszszsz opened this issue Sep 12, 2016 · 0 comments · Fixed by #151
Assignees
@szszszsz
Milestone
0.5

Comments

@szszszsz
Copy link
Member

Make sure OTP secret buffer is cleared and sent whole each time. Currently empty string is sent (one 0 byte).
Connected with:
@szszszsz szszszsz modified the milestone: 0.5 Sep 12, 2016
@szszszsz szszszsz mentioned this issue Sep 21, 2016
Merged
@szszszsz szszszsz self-assigned this Sep 21, 2016
szszszsz added a commit that referenced this issue Sep 21, 2016
@szszszsz
Merge pull request #151 from Nitrokey/issue_138-send_20_null_bytes_fo…
c7b9b82 
…r_secret

Refactoring: mainWindow::on_writeButton. #138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szszszsz szszszsz

Labels
None yet
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

Refactoring: mainWindow::on_writeButton Nitrokey/nitrokey-app
1 participant
@szszszsz