Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when showing message box #142

Closed
szszszsz opened this issue Sep 19, 2016 · 1 comment
Closed

Crash when showing message box #142

szszszsz opened this issue Sep 19, 2016 · 1 comment
Assignees
@szszszsz
Milestone
0.5

Comments

@szszszsz
Copy link
Member

szszszsz commented Sep 19, 2016 •
edited

Application crashes when showing i-th message box.
Issue possibly linked with Ubuntu and Qt version lower than 5.6.
Occurs on master, tags 0.2 0.3.2 0.4

Ubuntu 16.04
g++ (Ubuntu 5.4.0-6ubuntu1~16.04.2) 5.4.0 20160609
qt5-qmake: Version: 5.5.1+dfsg-16ubuntu7
Nitrokey Pro with 10 OTP slots occupied

Scenario:

  1. Tray -> Configure -> OTP and Password Safe
  2. Erase 10 consecutive OTP slots
  3. On 5th+ 'Success' window application will crash

Issue is not occurring with Nitrokey Storage or it occurs later than for Pro.
@szszszsz szszszsz added this to the 0.5 milestone Sep 19, 2016
@szszszsz szszszsz self-assigned this Sep 19, 2016
@szszszsz
Copy link
Member Author

It appears that issue is caused by data races. No mutexes are locked during calls from Qt Timers.
Discovered with debugging using Asan.

szszszsz added a commit that referenced this issue Sep 20, 2016
@szszszsz
Fixing crashes on stack 6 valgrind #142
9e3e266 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
szszszsz added a commit that referenced this issue Sep 20, 2016
@szszszsz
Fixing crashes on stack 6 valgrind #142
7aca03f 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz szszszsz mentioned this issue Sep 21, 2016
Merged
@szszszsz szszszsz mentioned this issue Sep 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szszszsz szszszsz

Labels
None yet
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@szszszsz