Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash-completion file can end up being installed into /usr/etc/ #453

Closed
Polynomial-C opened this issue Aug 13, 2020 · 5 comments · Fixed by #454
Closed

bash-completion file can end up being installed into /usr/etc/ #453

Polynomial-C opened this issue Aug 13, 2020 · 5 comments · Fixed by #454
Labels
bug os:linux packaging prio:medium
Milestone
1.5

Comments

@Polynomial-C
Copy link

Steps to reproduce:

  • Make sure you don't have a bash-completion.pc file installed
  • run cmake with -DCMAKE_INSTALL_PREFIX=/usr (this is what Gentoo ebuild is doing)

Result:

bash-completion file gets installed into /usr/etc/bash_completion.d/

Possible solution:

Let this be overridable by setting (for example) -DBASH_COMPLETION_DIR="/some/path" and only do your path magic when this has not been set by the user.
@szszszsz szszszsz added this to the 1.5 milestone Aug 14, 2020
@SoapGentoo SoapGentoo mentioned this issue Aug 16, 2020
Merged
@szszszsz
Copy link
Member

szszszsz commented Aug 17, 2020 •
edited

Hi @Polynomial-C !

Thank you for the report! It should be fixed now thanks to @SoapGentoo, with #454. Do you need a quick release for packaging?

@SoapGentoo
Copy link
Contributor

@szszszsz quick release would help us, then I can quickly add it and remove the patches

@szszszsz
Copy link
Member

Noted! Should be done in next 24h.

@szszszsz
Copy link
Member

Done at https://github.com/Nitrokey/nitrokey-app/releases/tag/v1.4.2
Sorry for the delay!

@SoapGentoo
Copy link
Contributor

Thanks a lot for being so responsive to our requests!

gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Aug 20, 2020
@SoapGentoo
app-crypt/nitrokey-app: Version bump to 1.4.2
c5b5cd0 
Closes: https://bugs.gentoo.org/736956
Closes: Nitrokey/nitrokey-app#453
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: David Seifert <soap@gentoo.org>
NeddySeagoon pushed a commit to NeddySeagoon/gentoo-arm64 that referenced this issue Aug 21, 2020
@SoapGentoo @NeddySeagoon
app-crypt/nitrokey-app: Version bump to 1.4.2
add8538 
Closes: https://bugs.gentoo.org/736956
Closes: Nitrokey/nitrokey-app#453
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: David Seifert <soap@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug os:linux packaging prio:medium
Projects
None yet
Milestone
1.5
Development

Successfully merging a pull request may close this issue.

Make BASH_COMPLETION_DIR user overridable
3 participants
@Polynomial-C @SoapGentoo @szszszsz