Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usability of hidden volume setup form #72

Closed
3 of 4 tasks
szszszsz opened this issue May 25, 2016 · 15 comments
Closed
3 of 4 tasks

Improve usability of hidden volume setup form #72

szszszsz opened this issue May 25, 2016 · 15 comments
Assignees
Labels
Milestone

Comments

@szszszsz
Copy link
Member

szszszsz commented May 25, 2016

List:

  • improve general elements layout
  • add more help description (what is 'entropy' rank? what password should be chosen? chars range for password, hidden slots description, how possible hidden volume size is changing in regard of partition type of encrypted volume or its available free space? could hidden volume be overwritten by data from encrypted volume?)
  • fix tab jumps between fields
  • improve password input and entropy information
@jans23
Copy link
Member

jans23 commented Jul 8, 2016

See also the old ticket.

@jans23 jans23 added this to the 0.5 milestone Jul 8, 2016
@szszszsz
Copy link
Member Author

szszszsz commented Aug 11, 2016

Old ticket suggestions:

  • Check maximum password field length
  • Use MB instead of percentages
  • Position hidden volume at the end of free space
  • Inform how much password entropy is safe
  • Add instructions on top of the dialog

@jans23
Copy link
Member

jans23 commented Aug 11, 2016

@szszszsz Let me know if you need more specific information or want some feedback on your solution.

szszszsz added a commit that referenced this issue Aug 11, 2016
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Copy link
Member Author

Hi @jans23 !
Could you please then check solution on branch issue_72-hidden_setup_usability and give feedback?
Adding more instructions (regarding password real strength and hidden volume characteristics) would need to move from window form to setup wizard. Would you like it to do so?
Is default position (70-90%) of hidden volume acceptable?

@szszszsz
Copy link
Member Author

Wizard might be done separately and run only if user wish for it (so experienced user would not have to go all the way with wizard forms and had all on one page)

@jans23
Copy link
Member

jans23 commented Aug 12, 2016

"Use MB instead of percentages" shouldn't be checked yet, right? At lest for me its still displayed in percentage.

The window has some problems. See: hidden volume setup

I suggest to add a big disclaimer on top of the window. For instance: "You should understand the properties of hidden volumes before proceeding. Please read these instructions.

@szszszsz
Copy link
Member Author

Interesting. What OS do you use?
It looks like this on my side:
hidden volume window correct

@jans23
Copy link
Member

jans23 commented Aug 12, 2016

Ubuntu 16.04 with Unity. The App is compiled with qmake.

@szszszsz
Copy link
Member Author

I have designed the form with rescaled down desktop (with factor 0.75) and this is the cause of different view. I will check factor 1.0.

szszszsz added a commit that referenced this issue Aug 12, 2016
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Copy link
Member Author

Fixed. Please check latest commit.

@jans23
Copy link
Member

jans23 commented Aug 12, 2016

Yes, now the window looks correct and very nice!

Here are a few more suggestions:

  • Disclaimer at the top: Please make it bold. In the "About" window we use a triangular warning icon. Perhaps put it left from the disclaimer.
  • Change disclaimer to "You should understand the properties of hidden volumes before proceeding. It can destroy your encrypted data! Please read these instructions first."
  • Add instructions below the disclaimer: "1. You may want to copy some innocuous files to the encrypted data. 2. Configure hidden volumes in this dialogue. 3. Once you configured a hidden volume you must not use/write to the encryption volume anymore. Otherwise it may destroy the data in your hidden volume."
  • Suggestion for the text: "Start/End hidden volume at %/MB/GB of the encrypted storage
  • "SD size" -> "Storage capacity"
  • I don't understand the last sentence ("Size will be rounded..."). Perhaps remove it?
  • Perhaps remove the lines "Entropy guess..." and "using human..." ?
  • Is "10% and 90%" static text or where do those values come from?

@szszszsz
Copy link
Member Author

The 10% and 90% are hardcoded values. I guess these are set to omit filesystem structures.
As for Size will be rounded - hidden volume creation command has in its parameters size given in integral percent, thus final size will be rounded down to multiplicity of 1% of storage size.

@szszszsz
Copy link
Member Author

Please check latest commit.

@szszszsz szszszsz self-assigned this Aug 24, 2016
szszszsz added a commit that referenced this issue Aug 24, 2016
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
szszszsz added a commit that referenced this issue Aug 24, 2016
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Copy link
Member Author

Hi @jans23 !
Is the current solution acceptable?

szszszsz added a commit that referenced this issue Aug 25, 2016
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
szszszsz added a commit that referenced this issue Aug 25, 2016
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
szszszsz added a commit that referenced this issue Sep 23, 2016
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
szszszsz added a commit that referenced this issue Sep 23, 2016
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
szszszsz added a commit that referenced this issue Sep 23, 2016
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Copy link
Member Author

Please request further improvements in new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants