Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent make install dirty the root filesystem, stick to the prefix #89

Merged
merged 9 commits into from Sep 27, 2016
Merged

prevent make install dirty the root filesystem, stick to the prefix #89

merged 9 commits into from Sep 27, 2016

Conversation

szszszsz
Copy link
Member

@szszszsz szszszsz commented Jun 20, 2016 •
edited

Contains fixes from:

Fixes #11

@szszszsz szszszsz modified the milestone: 0.5 Jul 13, 2016
@szszszsz szszszsz added the ready label Aug 27, 2016
@szszszsz szszszsz force-pushed the issue_prevent_make_install_dirty_the_root_filesystem branch from 4e452a0 to 45c8d2c Compare August 30, 2016 08:45
szszszsz pushed a commit that referenced this pull request Aug 30, 2016
@aagit @szszszsz
Prevent make install dirty the root filesystem, stick to the prefix
a78f44a 
(pull #89)

Signed-off-by: Andrea Arcangeli <andrea@kernel.org>
szszszsz added a commit that referenced this pull request Aug 30, 2016
@szszszsz
Compile support for libappindicator by default
45c8d2c 
(pull #89)

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Copy link
Member Author

@jans23 An additional review from someone knowing package building systems will be helpful.

@szszszsz szszszsz mentioned this pull request Aug 30, 2016
Closed
@szszszsz szszszsz force-pushed the issue_prevent_make_install_dirty_the_root_filesystem branch 3 times, most recently from f0cd7ca to 5fce418 Compare August 30, 2016 14:02
@szszszsz szszszsz mentioned this pull request Sep 1, 2016
Closed
@szszszsz szszszsz mentioned this pull request Sep 9, 2016
Closed
aagit and others added 9 commits September 27, 2016 12:04
@aagit @szszszsz
Prevent make install dirty the root filesystem, stick to the prefix
7a41144 
(pull #89)

Signed-off-by: Andrea Arcangeli <andrea@kernel.org>
@szszszsz
Compile support for libappindicator by default
fae6221 
(pull #89)

Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Change installation paths for CMake (as in pull #14)
352220f 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz
Add check in CMakeLists for libappindicator #11
6a83493
@szszszsz
CMake: increase minimum version and set policy. Include all found mod…
2c312a8 
…ules.
@szszszsz
CMake modules for searching libnotify #11
64cfcda
@szszszsz
Check in CMake for libnotify library and headers
bdd73ca
@szszszsz
Check for GTK2 with pkg-config
25117ab
@szszszsz
Check in CMake for libusb includes and library #11
208da19 
Signed-off-by: Szczepan Zalega <szczepan@nitrokey.com>
@szszszsz szszszsz force-pushed the issue_prevent_make_install_dirty_the_root_filesystem branch from b9eacc6 to 208da19 Compare September 27, 2016 10:09
@szszszsz szszszsz merged commit b43d93f into master Sep 27, 2016
@szszszsz szszszsz deleted the issue_prevent_make_install_dirty_the_root_filesystem branch September 27, 2016 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help wanted packaging
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

Various packaging related problems
2 participants
@szszszsz @aagit