-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump spsdk, cryptography #364
Conversation
I think for spsdk the test would be just running Nitrokey 3 update. |
Yes, for |
Rebased, but fails on mypy check:
Needs update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to deal with mypy errors.
I can't test the FIDO CLI commands, since these are not fixed yet (!), missing the API update of the |
This patch bumps cryptography to 39.0.1 which fixes two vulnerabilities: https://github.com/Nitrokey/pynitrokey/security/dependabot/1 https://github.com/Nitrokey/pynitrokey/security/dependabot/2 This also requires bumping spsdk, which allows us to drop some workarounds for fixed issues.
2bca73c
to
25dc4f1
Compare
Rebased again and updated to spsdk v1.10.1 to avoid the logging issue. Did you update the venv before running mypy? The errors you listed are caused by an incompatible spsdk version. |
lgtm, did some tests:
remaining tests with nk3am:
|
This patch bumps cryptography to 39.0.1 which fixes two vulnerabilities:
https://github.com/Nitrokey/pynitrokey/security/dependabot/1
https://github.com/Nitrokey/pynitrokey/security/dependabot/2
This also requires bumping spsdk to 1.9.0, which allows us to drop some workarounds for fixed issues. Note that 1.9.0 adds a default log handler for the spsdk module which we have to remove manually so that stdout is not cluttered with log messages.
Checklist
Make sure to run
make check
andmake fix
before creating a PR, otherwise the CI will fail.Test Environment and Execution