Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nkpk test: do not skip the status test #505

Merged
merged 1 commit into from Mar 4, 2024
Merged

Conversation

sosthene-nitrokey
Copy link
Contributor

niitropy nkpk test skipped the status test when it shouldn't

Changes

  • Fix nkpk test not checking the status of the device

Checklist

Make sure to run make check and make fix before creating a PR, otherwise the CI will fail.

  • tested with Python3.9
  • signed commits
  • updated documentation (e.g. parameter description, inline doc, docs.nitrokey)
  • added labels

Test Environment and Execution

  • OS:
  • device's model: nkpk and nk3am
  • device's firmware version: 1.0.0 and 1.6.0

Relevant Output Example

found 1 Nitrokey Passkey device(s):
- Nitrokey Passkey at /dev/hidraw8

Running tests for Nitrokey Passkey at /dev/hidraw8

[1/4]	uuid     	UUID query              	SUCCESS  	850E04AF076D2AA60000000000000000
[2/4]	version  	Firmware version query  	SUCCESS  	v1.0.0
[3/4]	status   	Device status           	SKIPPED  	
Please press the touch button on the device ...
Please press the touch button on the device ...
[4/4]	fido2    	FIDO2                   	SUCCESS  	

4 tests, 3 successful, 1 skipped, 0 failed

Fixes #504

@sosthene-nitrokey sosthene-nitrokey merged commit 6014f88 into master Mar 4, 2024
8 checks passed
@sosthene-nitrokey sosthene-nitrokey deleted the nkpk-status-skip branch March 4, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nkpk: test skips the status test
3 participants