Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add view for affected packages per channel #140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alejandrosame
Copy link
Collaborator

@alejandrosame alejandrosame commented Dec 18, 2023

Create a simple tabbed view for those derivations that appear in an issue marked as 'affected'.

The styles broke in weird ways when moved to the main style.css, so I leave them in the template document for the time being.

@@ -368,3 +369,41 @@ class AdvisorySeverity(models.TextChoices):
CRITICAL = "CRITICAL", _("critical")

issues = models.ManyToManyField(NixpkgsIssue)


class NixDerivationAffectedView(models.Model):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand here, shouldn't the list of derivations affected derive from an NixpkgsIssue?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's how the function view affected_derivation_per_channel_view is defined.

In any case, I'll push a change soon where I'll get rid of the view table and achieve the same with a queryset.

@alejandrosame alejandrosame marked this pull request as ready for review December 19, 2023 19:31
Create a simple tabbed view for those derivations that appear in
an issue marked as 'affected'.

The styles broke in weird ways when moved to the main  `style.css`,
so I leave them in the template document for the time being.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants