set up groups and permissions #67
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the CVE container was misplaced on the issue data model. this change also adds lots of convenience for the admin backend, because currently maintainer data is not ingested from the evaluation dump.
also refactor the Nix setup, which didn't actually work: the overlay packages did not end up in the final package set. now they are.
fricklerhandwerk
force-pushed
the
users-groups-perms
branch
from
2afb961
to
c9c0d09
Compare
| def ensure_groups(sender, **kwargs): | ||
| from django.contrib.auth.models import Group | ||
|
|
||
| secteam, created = Group.objects.get_or_create(name="Security team") |
There was a problem hiding this comment.
Why do we make dynamic groups? This feel overly complicated? All our groups are statically known: superadmins, security team, committers, maintainers, viewers. Do you want to bring more groups than those?
RaitoBezarius
requested changes
Dec 7, 2023
|
Ah I think I fucked up my commits and the missing commit for you is here: 67dd36d. |
|
The important part for permissions will be the REST API we will build, we have https://www.django-rest-framework.org/api-guide/permissions/ for that. |
|
For views, we already have the built-in system in https://docs.djangoproject.com/en/5.0/topics/auth/default/#permissions-and-authorization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.