Job evaluator doesn't receive -I' flag for sysbuild' inputs

[civodul]

Hello,

inputsToArgs' doesn't pass any-I' flag for sysbuild inputs when there are several builds for that input.

I'm not sure how to fix that since `inputsToArgs' is system-oblivious.

Thanks,
Ludo'.

[edolstra]

Why should it pass -I for sysbuild inputs? In any case, if there are several values for an input, then it's not possible to pass the input using -I.

[civodul]

Well, why would it pass -I for builds, and not for sysbuilds? It seems to me that the same programming style should be available regardless of whether the input is a "build" or "sysbuild".

When there are several values for an input, inputsToArgs could be changed to return -I just for the input that matches the required system type.

WDYT?

[civodul]

Ping!

[edolstra]

Okay, from looking at the code, it seems that sysbuild inputs do cause a -I flag to be passed, if there is only one alternative, same as with "build". But with sysbuild there are usually multiple alternatives so you don't get a -I flag.

It's not possible to return -I only for the matching system type, because the evaluator is called only once (i.e. for all system types at the same time).

[civodul]

Thanks for looking into it.

It's not clear to me why it's not possible to add -I for the matching system type. We know what system type we are building for, and we know what sysbuilds are available for that system type, don't we?

[edolstra]

We don't know what system type we are building for. We only know that after calling the evaluator.

[gilligan]

@edolstra i can't quite make sense of this issue. Should it be closed as a WONTFIX?