Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitBucketStatus.pm plugin fails on emailresponsible check #617

Open
christian-marie opened this issue Nov 29, 2018 · 0 comments
Open

BitBucketStatus.pm plugin fails on emailresponsible check #617

christian-marie opened this issue Nov 29, 2018 · 0 comments

Comments

@christian-marie
Copy link

I'm not sure if this is due to our particular configuration or an interface change, but the BitBucketStatus.pm plugin wasn't working for me:

hydra-queue-runner[8207]: Hydra::Plugin::BitBucketStatus=HASH(0x7c49c98)->buildFinished: Can't call method "emailresponsible" on an undefined value at /nix/store/d94rbw7i2ng8hiwdys8hlniwhr1ffhx3-hydra-0.1.31337.f9870b5fce854430b80fbd4d68c3ed0c69f50822/libexec/hydra/lib/Hydra/Plugin/BitBucketStatus.pm line 42.

I ended up getting it working simply by removing the check:

 
--- src/src/lib/Hydra/Plugin/BitBucketStatus.pm	2018-11-29 17:01:24.626368460 +1100
+++ src-2/src/lib/Hydra/Plugin/BitBucketStatus.pm	2018-11-29 17:04:39.359779607 +1100
@@ -37,10 +37,6 @@
             foreach my $i ($eval->jobsetevalinputs){
                 next unless defined $i;
 
-                # Skip if the emailResponsible field is disabled
-                my $input = $eval->jobset->jobsetinputs->find({name => $i->name });
-                next unless $input->emailresponsible;
-
                 my $uri = $i->uri;
                 my $rev = $i->revision;
                 # Skip if the uri is not a bitbucket repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant