Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: add oneplus-oneplus3 #31

Merged
merged 6 commits into from
Oct 5, 2019

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Oct 5, 2019

What an inspiring codename! The oneplus-oneplus3, better known as the OnePlus 3!

I'm not making the rules here... Well, I am, but I'm not the one making a device with an uninspired name!


Cleaned up the tree, everything works just as it does for asus-z00t.

@samueldr samueldr changed the title device: add oneplus-oneplus3 [WIP] device: add oneplus-oneplus3 Oct 5, 2019
@samueldr samueldr force-pushed the device/oneplus-oneplus3 branch 2 times, most recently from 2b3e443 to 25d9017 Compare October 5, 2019 04:59
libinput, which I believe, claims there is a kernel bug with the
synaptics driver touchscreen in use.

This is the recommended fix according to PostmarketOS.

 * https://wiki.postmarketos.org/wiki/Troubleshooting:touchscreen#sec_touchscreen:_kernel_bug

I have not seen any issues from using this fix.

The error:

```
synaptics: kernel bug: device has min == max on ABS_MT_WIDTH_MAJOR
```

According to the touchscreen documentation of the kernel, I don't think
that it is an issue to remove this information from touch events.
@samueldr samueldr changed the title [WIP] device: add oneplus-oneplus3 device: add oneplus-oneplus3 Oct 5, 2019
@samueldr samueldr marked this pull request as ready for review October 5, 2019 05:08
@samueldr samueldr added the 4. type: port New device port label Oct 5, 2019
@samueldr samueldr merged commit b5081df into mobile-nixos:master Oct 5, 2019
@samueldr
Copy link
Member Author

samueldr commented Oct 5, 2019

@andir confirmed it also works on oneplus3t. At least stage-1 does.

@samueldr samueldr deleted the device/oneplus-oneplus3 branch October 5, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. type: port New device port
Development

Successfully merging this pull request may close these issues.

1 participant