Don’t skip over > in angle-path

Fixes #94
NixOS · May 10, 2020 · 9242165 · 9242165
1 parent ddf0917
commit 9242165
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/nix-mode.el b/nix-mode.el
@@ -418,7 +418,7 @@ STRING-TYPE type of string based off of Emacs syntax table types"
        (right " -bseqskip- ")
        (left " -fseqskip- "))))))
 
-(defconst nix-smie--symbol-chars ":->|&=!</-+*?,;!")
+(defconst nix-smie--symbol-chars "[:->|&=!</-+*?,;!]")
 
 (defconst nix-smie--infix-symbols-re
   (regexp-opt '(":" "->" "||" "&&" "==" "!=" "<" "<=" ">" ">="
@@ -573,8 +573,8 @@ STRING-TYPE type of string based off of Emacs syntax table types"
        (point)
        (progn
          (or (/= 0 (skip-syntax-forward "'w_"))
-             (/= 0 (skip-chars-forward nix-smie--symbol-chars))
+             (when (looking-at nix-smie--symbol-chars) (forward-char) t)
-             (skip-syntax-forward ".'"))
+             (skip-syntax-forward "'"))
          (point)))))
 
 (defun nix-smie--forward-token ()
@@ -595,8 +595,8 @@ STRING-TYPE type of string based off of Emacs syntax table types"
        (point)
        (progn
          (or (/= 0 (skip-syntax-backward "'w_"))
-             (/= 0 (skip-chars-backward nix-smie--symbol-chars))
+             (when (looking-back nix-smie--symbol-chars) (backward-char) t)
-             (skip-syntax-backward ".'"))
+             (skip-syntax-backward "'"))
          (point)))))
 
 (defun nix-smie--backward-token ()

diff --git a/tests/nix-mode-tests.el b/tests/nix-mode-tests.el
@@ -227,6 +227,12 @@ Related issue: https://github.com/NixOS/nix-mode/issues/72"
   "Proper indentation of strings in a multi-line string."
   (with-nix-mode-test ("issue-78.nix" :indent 'smie-indent-line)))
 
+(ert-deftest nix-mode-test-indent-issue-94 ()
+  "Proper indentation of attrsets inside of lists inside of attrsets.
+
+Related issue: https://github.com/NixOS/nix-mode/issues/94"
+  (with-nix-mode-test ("issue-60.1.nix" :indent 'smie-indent-line)))
+
 (ert-deftest nix-mode-test-indent-lambdas-smie ()
   "Proper indentation of function bodies."
   (with-nix-mode-test ("smie-lambdas.nix" :indent 'smie-indent-line)))

diff --git a/tests/testcases/issue-94.nix b/tests/testcases/issue-94.nix
@@ -0,0 +1,6 @@
+let
+  nixpkgs = <nixpkgs>;
+  wrongIndentedLine = true;
+in {
+  a = "b";
+}