Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files containg checksums doesn't contain file names #224

Closed
a12l opened this issue Jun 6, 2018 · 1 comment · Fixed by NixOS/nixos-channel-scripts#17
Closed

Files containg checksums doesn't contain file names #224

a12l opened this issue Jun 6, 2018 · 1 comment · Fixed by NixOS/nixos-channel-scripts#17

Comments

@a12l
Copy link

a12l commented Jun 6, 2018

Page: https://github.com/NixOS/nixos-homepage/blob/master/nixos/download.tt
Lines: 36, 45-46 and 63
CC: @grahamc (as asked by him in the IRC channel)

The files containing the SHA256 checksums should contain the file names after the checksum. E.g. the current checksum file for Graphical live CD, 64-bit Intel/AMD should contain the following

1bcd44d8b2c60a18a39a60dcf80c50b230ab24950130dddacc0b5ed12718e369 nixos-graphical-18.03.132618.0f73fef53a9-x86_64-linux.iso

The reason why the file should contain the file name is to enable users to verify the checksum easily with the command sha256 -c [file].iso.sha256.

@samueldr
Copy link
Member

samueldr commented Jun 6, 2018

Where this seems to happen:

The manpage says:

The sums are computed as described in FIPS-180-2. When checking, the input should be a former
output of this program. The default mode is to print a line with checksum, a space, a character
indicating input mode ('*' for binary, ' ' for text or where binary is insignificant),
and name
for each FILE.

So it looks like write_file("$dstFile.sha256", "$sha256_expected $dstFile"); (two spaces) could work?

EDIT : github markdown ate a space inside the <code> block beforehand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants