Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

News page wider than viewport #543

Closed
davidak opened this issue Sep 20, 2020 · 2 comments · Fixed by #583
Closed

News page wider than viewport #543

davidak opened this issue Sep 20, 2020 · 2 comments · Fixed by #583
Labels
bug Something isn't working design About the design refresh work

Comments

@davidak
Copy link
Member

davidak commented Sep 20, 2020

signal-2020-09-21-002213

On Xiaomi Redmi Note 4 with Firefox Klar.

Reproducible on desktop Chromium.

Screenshot from 2020-09-21 00-44-31
@garbas garbas added bug Something isn't working design About the design refresh work labels Sep 21, 2020
@samueldr
Copy link
Member

This is caused by the table-based layout.

There are elements that would normally end up being set to a max-width properly, but inside a table rules are just slightly different due to legacy reasons.

The solution here is to change the news rendering in the xsl so it doesn't use a table anymore.

@samueldr samueldr mentioned this issue Sep 25, 2020
Merged
@garbas
Copy link
Member

garbas commented Sep 27, 2020

How news are used on the website is going to be "radically" changed soon, right after the redesign, the work/discussion is being tracked in #446. But @samueldr 💯 for fixing it until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working design About the design refresh work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix news page breaking out of the layout NixOS/nixos-homepage
3 participants
@garbas @davidak @samueldr