-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX improvements for the expand mechanism #277
Comments
@piegamesde Do you maybe have some suggestion how would you fix the expand mechanism? Maybe a link to a site that does it better. |
Did the old site do something wrong in that regard? If I remember correctly, the whole list item was a button and it worked just fine. Alternatively, I see two approaches:
|
Sorry for jumping in but I think I might be best equipt to clarify few things. Before I do so I want to make it clear that we're glad that you've opened the issue because every data-point counts. That's being said for sake of tracking all the information I'll link few things related to the points.
This is not true. In fact the reason why the whole item is no longer clickable is to make keyboard navigation possible. See this issue: #259 . When whole item was clickable browser was unable to find any focusable element so keyboard navigation was not working. Fix to this issue than caused this issue #271 since having the keyboard focusable button element also means it's not possible to select text within the element using cursor (addressed in #275). TL;DR issue like this are hard to resolve because different people care about different things and it's hard to keep everyone happy. Anyway the keyboard selection does in fact work. as you can see: All you need to do is to use tab to select the title of item you want to expand and then press enter.
you can still click on title as far as I know before there was no button at all and thing opened by clicking on item. But then it was hard to select text - see #261 (comment)
This was raised before as well in #261 (review) and we hope to address it soon |
Doing some issue maintenance while I plan my work. The expand mechanism is going to be address with #286 . |
UX of the expand mechanism can be improved in many points:
From #272 (comment). Sorry @garbas, no medal for me today ^^
The text was updated successfully, but these errors were encountered: