Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX improvements for the expand mechanism #277

Closed
4 tasks
piegamesde opened this issue Jan 25, 2021 · 4 comments
Closed
4 tasks

UX improvements for the expand mechanism #277

piegamesde opened this issue Jan 25, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@piegamesde
Copy link
Member

UX of the expand mechanism can be improved in many points:

  • It's not navigable by keyboard
  • The button is a lot smaller and thus harder to hit than before (Fitts' law)
  • The button says "Show/Hide package details" even when searching options
  • Placing the button onto the separator line is a weird choice. This makes it feel like the button is not related to one search entry, but between two. It also isn't 100% clear whether it refers to the item above or below the line.

From #272 (comment). Sorry @garbas, no medal for me today ^^

@garbas
Copy link
Member

garbas commented Jan 25, 2021

@piegamesde Do you maybe have some suggestion how would you fix the expand mechanism? Maybe a link to a site that does it better.

@garbas garbas added the bug Something isn't working label Jan 25, 2021
@piegamesde
Copy link
Member Author

Did the old site do something wrong in that regard? If I remember correctly, the whole list item was a button and it worked just fine. Alternatively, I see two approaches:

  1. Related to the previous way of doing it, have a toggle button on the side that expands the item down (think of Accordion menu)
  2. Have a "show more"/"show less", which would be more similar to the current implementation. Important there:
    • Make the button permanently visible and accessible by keyboard
    • Move the button above the separator line

@turboMaCk
Copy link
Member

turboMaCk commented Jan 25, 2021

Sorry for jumping in but I think I might be best equipt to clarify few things.

Before I do so I want to make it clear that we're glad that you've opened the issue because every data-point counts. That's being said for sake of tracking all the information I'll link few things related to the points.

It's not navigable by keyboard

This is not true. In fact the reason why the whole item is no longer clickable is to make keyboard navigation possible. See this issue: #259 . When whole item was clickable browser was unable to find any focusable element so keyboard navigation was not working. Fix to this issue than caused this issue #271 since having the keyboard focusable button element also means it's not possible to select text within the element using cursor (addressed in #275).

TL;DR issue like this are hard to resolve because different people care about different things and it's hard to keep everyone happy.

Anyway the keyboard selection does in fact work. as you can see:

keyboard-selection

All you need to do is to use tab to select the title of item you want to expand and then press enter.

The button is a lot smaller and thus harder to hit than before (Fitts' law)

you can still click on title as far as I know before there was no button at all and thing opened by clicking on item. But then it was hard to select text - see #261 (comment)

Placing the button onto the separator line is a weird choice

This was raised before as well in #261 (review) and we hope to address it soon

@garbas
Copy link
Member

garbas commented Feb 6, 2021

Doing some issue maintenance while I plan my work. The expand mechanism is going to be address with #286 .

@garbas garbas closed this as completed Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants