Fix updates (another try) #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And make it also build the autoPrUpdate derivation
See #20 (comment) We fix this by telling the update scripts explicitly which files they should update and passing that information in from CI
philiptaron
reviewed
Mar 21, 2024
|
Btw best reviewed with whitespace hidden |
philiptaron
approved these changes
Mar 21, 2024
|
We're almost there.. #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the previous problem (#20 (comment)) with the second commit.
Also using this opportunity to improve how we define what CI should build and make it build the automated update script (but not running it), see the first commit for that.
This makes sure that when we make changes to the update script (like in this PR), it at least gets at least built (though not ran).