Fix cargo missing in dev env #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah strange. I don't have it installed globally either. In my forked copy of this repo, in older branches, I have cargo so it's coming from somewhere else in the derivation somehow. |
willbush
approved these changes
Apr 18, 2024
|
Isn't it coming from |
lazyDerivation ended up filtering out .nativeBuildInputs and co., which mkShell's inputsFrom relies on to figure out what to use for the environment..
|
Figured it out, |
philiptaron
approved these changes
Apr 18, 2024
|
Yeah agreed 馃槄 Maybe let's just not bother trying to make I'll update it shortly |
The lazyDerivation part to try to make it less messy ends up just making the code messy instead, let's just drop it and not worry about making `nix-build` without arguments work. Instead `nix-build -A build` works, and this also keeps the resulting attribute set cleaner in general.
That's what they are :)
philiptaron
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No idea how I didn't notice it missing before..Must've come from somewhere else 馃しTurns out
lazyDerivation(added in 3f361a4) ended up filtering out .nativeBuildInputs and co., which mkShell's inputsFrom relies on to figure out what to use for the environment.. 馃う