Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: when a build fails for a PR, also try building the same attrpath without merging the PR #143

Open
ryantm opened this issue Mar 22, 2018 · 2 comments

Comments

@ryantm
Copy link
Member

ryantm commented Mar 22, 2018

It would be nice if when a build fails, ofborg would try to build the same attrpath on the target branch without the PR merged. I think this would help people merging pull requests. For example, they can be less worried about merging a broken darwin build if it also doesn't build on master.

@ryantm ryantm changed the title Feature request: when a build fails say if it ever succeeded Feature request: when a build fails, say if it ever succeeded Mar 22, 2018
@timokau
Copy link
Member

timokau commented Oct 31, 2018

ofBorg could even retry the build without the PR in question. That probably wouldn't add too much load and may be easier to implement.

@ryantm
Copy link
Member Author

ryantm commented Oct 31, 2018

That's a good idea. I'll change the original post to ask for that. For reference it used to be:

Feature request: when a build fails, say if it ever succeeded

It would be nice if when a build fails, the comment says if it ever succeeded in the past. I think this would help people merging pull requests because, for example, they can be less worried about a darwin failure if there is no record of the package ever building successfully on darwin.

@ryantm ryantm changed the title Feature request: when a build fails, say if it ever succeeded Feature request: when a build fails for a PR, also try building the same attrpath without the PR Oct 31, 2018
@ryantm ryantm changed the title Feature request: when a build fails for a PR, also try building the same attrpath without the PR Feature request: when a build fails for a PR, also try building the same attrpath without merging the PR Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants