Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternatives key for listing other possible language matches #19

Merged
merged 14 commits into from Jun 29, 2023

Conversation

Nixinova
Copy link
Owner

Contains files that are classified using the fallback language and lists what languages it could be.
Lists files and a list of matches under files.alternatives

Contains files that are classified using the fallback language and lists what languages it could be.
@Nixinova Nixinova added enhancement New feature or request classification Related to classifying files in progress This is being worked on labels Mar 16, 2023
@Nixinova Nixinova changed the base branch from delete to main June 25, 2023 05:54
@Nixinova
Copy link
Owner Author

Nixinova commented Jun 25, 2023

To determine: Should alternatives include the result?

"files": {
  "/x.pluginspec": "Ruby",
},
"alternatives": {
  "/x.pluginspec": ["Ruby", "XML"],
},
or
"files": {
  "/x.pluginspec": "Ruby",
},
"alternatives": {
  "/x.pluginspec": ["XML"],
},
?

@Nixinova
Copy link
Owner Author

Nixinova commented Jun 28, 2023

Should alternatives include the result?

I'll go with no so that if (alternatives.length>0) {...} may be used

@Nixinova Nixinova merged commit daaf868 into main Jun 29, 2023
5 checks passed
@Nixinova Nixinova deleted the feat-unsure-object branch June 29, 2023 11:24
@Nixinova Nixinova added implemented This feature has been added and removed in progress This is being worked on labels Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Related to classifying files enhancement New feature or request implemented This feature has been added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an unsure boolean key per file result
1 participant