fix cast error and change unit of measure of distance, fix #15 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue explanation: - distance is initially computed as a timedelta in nanoseconds - the fix for end of date range `distance[distance > 183] = 365 - distance[distance > 183]` fails in the comparison `distance > 183` and is actually assuming that distance is in days fix explanation: - distance is explictly converted to be measure in days related change: - removed the conversion of distance to be measured in minutes, it will stay measured in days (I do not think this would affect the rest, but I might be mistaken
|
|
|
Hey! Closing this PR since this was related to a previous repo version. Now, the repo contains the python SDK to access TimeGPT. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue explanation:
distance[distance > 183] = 365 - distance[distance > 183]fails in the comparisondistance > 183and is actually assuming that distance is in daysfix explanation:
related change: