bypass getItem on keys-only db streams (re-rebased) #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lol, zuul broke too, but now after that update, we should be good... |
nolanlawson
force-pushed
the
fastkeys-nolan
branch
from
7f60dbb
to
90f62b8
Compare
nolanlawson
force-pushed
the
fastkeys-nolan
branch
from
90f62b8
to
626a971
Compare
nolanlawson
force-pushed
the
fastkeys-nolan
branch
from
626a971
to
699e5ba
Compare
|
Changes Unknown when pulling 699e5ba on fastkeys-nolan into ** on master**. |
|
Tested manually, it's fine. Ngrok is just giving me headaches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should pass, now that localstorage-memory is updated. I also fixed the test to ensure the database is closed.