Comment on height150 (with axis tracing).

NoCheatPlus · Nov 24, 2016 · 0a83462 · 0a83462
1 parent ae44be5
commit 0a83462
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/...ore/src/main/java/fr/neatmonster/nocheatplus/utilities/collision/PassableAxisTracing.java b/...ore/src/main/java/fr/neatmonster/nocheatplus/utilities/collision/PassableAxisTracing.java
@@ -45,6 +45,12 @@ protected boolean step(final int blockX, final int blockY, final int blockZ,
             final double maxX, final double maxY, final double maxZ, 
             final Axis axis, final int increment) {
         if (BlockProperties.isPassableBox(blockCache, blockX, blockY, blockZ, minX, minY, minZ, maxX, maxY, maxZ)) {
+            /*
+             * TODO: HEIGHT150 -> if not passable... how/where to test for block
+             * change tracker? E.g.: y-offset from block < 0.5 -> check the
+             * block underneath. (one method check box normal + opportunistic
+             * past state handling in one?)
+             */
             return true;
         }
         // TODO: if (blockChangeTracker != null && -- check with BlockChangeTracker and BlockChangeReference --

diff --git a/NCPCore/src/main/java/fr/neatmonster/nocheatplus/utilities/map/BlockProperties.java b/NCPCore/src/main/java/fr/neatmonster/nocheatplus/utilities/map/BlockProperties.java
@@ -4092,6 +4092,10 @@ public static final int collectInitiallyCollidingBlocks(final BlockCache access,
                 }
             }
         }
+        /*
+         * Consider doing an xz iteration here for HEIGHT150, iff y-offset <=
+         * 0.5 (and possibly a flag is set).
+         */
         return added;
     }