Skip to content

Commit

Permalink
Do check for the other types of flying packets.
Browse files Browse the repository at this point in the history
  • Loading branch information
asofold committed Sep 6, 2015
1 parent f2f66c1 commit f2783cf
Showing 1 changed file with 5 additions and 6 deletions.
Expand Up @@ -51,11 +51,10 @@ public FlyingFrequency(Plugin plugin) {
// PacketPlayInFlying[3, legacy: 10]
super(plugin, ListenerPriority.LOW, new PacketType[] {
PacketType.Play.Client.FLYING,
// TODO: What with the other packets (specifically on player-join, compare PlayerMoveEvent)?
// PacketType.Play.Client.LOOK,
// PacketType.Play.Client.POSITION,
// PacketType.Play.Client.POSITION_LOOK
});
PacketType.Play.Client.LOOK,
PacketType.Play.Client.POSITION,
PacketType.Play.Client.POSITION_LOOK
});
}

@Override
Expand All @@ -78,7 +77,7 @@ public void onPacketReceiving(final PacketEvent event) {

final NetData data = dataFactory.getData(player);
data.lastKeepAliveTime = time; // Update without much of a contract.

// Counting all packets.
// TODO: Consider using the NetStatic check.
data.flyingFrequencyAll.add(time, 1f);
Expand Down

6 comments on commit f2783cf

@mibby
Copy link

@mibby mibby commented on f2783cf Sep 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asofold Any dev build? Jenkins didn't compile the latest 3 commits.

@Curtis3321
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mibby Just run maven, worked fine for me!

@mibby
Copy link

@mibby mibby commented on f2783cf Sep 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Curtis3321 When I run maven through netbean, it can't resolve the bukkit 1.8 dependency in NCPCore since it searches the bukkit repo.

@asofold
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build 850 done.

@mibby We changed NCP to run without any Spigot/CraftBukkit/nms dependencies by default, at least with Eclipse (see readme.md), it would use the cbreflect compat module then. Does it still not compile with NetBeans, due to the Bukkit dependency !? Would putting the spigot repository first work?

@asofold
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Bukkit-API we should switch to the official Spigot repo (not md-5.net)

@mibby
Copy link

@mibby mibby commented on f2783cf Sep 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asofold That is correct. It still does not compile with netbean due to requiring a bukkit 1.8 dependency from bukkit's outdated repo.

Please sign in to comment.