Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty scroll bar in code samples #69

Closed
zachfedor opened this issue Sep 5, 2016 · 3 comments
Closed

Empty scroll bar in code samples #69

zachfedor opened this issue Sep 5, 2016 · 3 comments
Assignees
Labels

Comments

@zachfedor
Copy link
Contributor

Tell us about the issue you are experiencing

Code sample styles include overflow-x: scroll; which shows unnecessary scroll bar.

More info in PR #68


Platform: OSX
OS Version: 10.11.6
Node Version: 5.3.0
NPM Version: 3.5.2
Astrum Version: 1.8.0

@RyanHavoc RyanHavoc added the bug label Sep 6, 2016
@RyanHavoc
Copy link
Member

@zachfedor I think you may have inadvertently fixed a bug. We never intended for the scrollbar to be shown and they don't appear in Chrome for OSX for me. What browser are you using?

@RyanHavoc RyanHavoc self-assigned this Sep 6, 2016
@zachfedor
Copy link
Contributor Author

@RyanHavoc I just figured out the problem. I'm also using Chrome but there is a setting in System Preferences under the General tab to control the appearance of scroll bars. I think OSX's default is to only show them while scrolling, but it still keeps the 17px (or whatever it is) space for it even if it doesn't show anything. I've been burned by this behavior before, so I set it to always show the scroll bars if they're there. I think it mirrors other platforms a bit better, but I could be wrong.

If this is just a system prefs thing, I'm fine with just changing my personal settings instead of changing default behavior. Another option is to change the default CSS but remove the user option in data.json so the theme config doesn't get bloated.

Now that I think of it, is it worthwhile adding an easier way for user's to add their own styles to Astrum so that they aren't changing app/css/styles.* which, I imagine, gets blown away on astrum update?

@RyanHavoc
Copy link
Member

@zachfedor I've fixed this in Astrum 2.0.0 which is now in pre-release, details here: https://github.com/NoDivide/astrum/releases/tag/2.0.0-rc.0

Hoping to have the full release out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants