Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all header title overridable. #88

Closed
laitine opened this issue Nov 17, 2016 · 3 comments
Closed

Make all header title overridable. #88

laitine opened this issue Nov 17, 2016 · 3 comments
Labels
feature request

Comments

@laitine
Copy link

laitine commented Nov 17, 2016

Tell us about the issue you are experiencing

When viewing on mobile the header title appears and is not overridable.

What behaviour would you expect?

The header title should be listed included in data.json or map to one of the current titles listed in data.json.

Screenshots / Screencast

pattern_library_header_title
@RyanHavoc
Copy link
Member

@laitine Yes I agree. It would be good to be able to set this in the data.json file. We'll add it to the list for the next release.

@laitine
Copy link
Author

laitine commented Nov 21, 2016

Great. Thanks!

@RyanHavoc
Copy link
Member

@laitine This has been resolved in version 1.9.2.

@RyanHavoc RyanHavoc changed the title Header title not overridable Make all header title overridable. Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@laitine @RyanHavoc