Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First steps to adjust for GooglePlay API v3 #53

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

fellek
Copy link

@fellek fellek commented Jan 20, 2020

Hi,
with #51 I saw, Playmaker was not possible to talk to Google Play Store any more. it seems there changed some API results in API v3. I'm really new to this API so I only made changes by guessing...
If you're facing the same issues and need hotfix you are welcome to use this, but there will be not full functionality.

Function of this Version

  • Search for APK
  • Download APK (few Apps fail to download, e.g. de.spiegel.android.app.spon)
  • Update fdroid repo
  • Delete APK from cache
  • Update applications cache
  • Show APK pictures
  • Show APK size in MB
  • make ready for Python3.8

Felix Mallek added 2 commits January 22, 2020 23:44
* make image preview available again
* make Apk formatted size  available again
remove recently added variables detailss / appDetails
@fellek fellek requested a review from NoMore201 January 25, 2020 13:50
Show Apk Rating Stars in all views
@Jonny007-MKD
Copy link

Hi, I merged your changes into my fork. Thank you for your work!
When updating my applications, I get this error:

  File "/usr/local/lib/python3.8/site-packages/playmaker/server.py", line 56, in check
    return service.check_local_apks()
  File "/usr/local/lib/python3.8/site-packages/playmaker/service.py", line 367, in check_local_apks
    print('%d == %d ?' % (app.get('details').get('appDetails')['versionCode'], details.get('details').get('appDetails')['versionCode']))
KeyError: 'versionCode'

Can you reproduce this?

@fellek
Copy link
Author

fellek commented Apr 18, 2020

Hi, I merged your changes into my fork. Thank you for your work!
When updating my applications, I get this error:

  File "/usr/local/lib/python3.8/site-packages/playmaker/server.py", line 56, in check
    return service.check_local_apks()
  File "/usr/local/lib/python3.8/site-packages/playmaker/service.py", line 367, in check_local_apks
    print('%d == %d ?' % (app.get('details').get('appDetails')['versionCode'], details.get('details').get('appDetails')['versionCode']))
KeyError: 'versionCode'

Can you reproduce this?

It seems you are runnig on Python3.8 is it correct?
My playmaker installation runs on Python3.7

@Jonny007-MKD
Copy link

Jonny007-MKD commented Apr 18, 2020

It seems you are runnig on Python3.8 is it correct?
My playmaker installation runs on Python3.7

Yes, that's correct (because that's what Docker downloaded :) ).
I could workaround this issue by removing the app causing the error (com.nxp.nfc.tagwriter) from PlayMaker

Felix Mallek added 4 commits May 29, 2020 10:57
update openjdk > 11
replace sdk-tools > commandlinetools
add pip fdroidserver
update openjdk > 11
replace sdk-tools > commandlinetools
add pip fdroidserver
update openjdk > 11
replace sdk-tools > commandlinetools
add pip fdroidserver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants