Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds accordion demo link #1611

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Adds accordion demo link #1611

merged 2 commits into from
Feb 1, 2024

Conversation

tesk9
Copy link
Contributor

@tesk9 tesk9 commented Jan 26, 2024

Component Catalog change only.

Screenshot 2024-01-26 at 4 36 11 PM

@tesk9 tesk9 requested review from a team and charbelrami and removed request for a team January 26, 2024 23:37
@krinhorn
Copy link
Contributor

I think this would be more parsable as a list if that wouldn't cause issues or if you aren't super against it. Ex:

  • The Accordion component is designed to be used when you have either a list or a tree of expandables. It may also be used when there's only one expandable.
  • Devs should watch the entirety of Tessa's Accordion demo before using. Discussion of how to attach styles correctly begins at 5:10.

@tesk9
Copy link
Contributor Author

tesk9 commented Jan 29, 2024

image

Copy link
Contributor

@charbelrami charbelrami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tesk9 tesk9 merged commit 460ec3a into master Feb 1, 2024
7 of 8 checks passed
@tesk9 tesk9 deleted the tessa/accordion-styling-warnings branch February 1, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants