Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version (new Menu function and css helpers, new genres icons #1660

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

erik-nri
Copy link
Contributor

@erik-nri erik-nri commented Mar 20, 2024

🏷️ Bump for version 28.3.0

What changes does this release include?

How has the API changed?

Please paste the output of elm diff run on latest master in the code block:

This is a MINOR change.

---- Nri.Ui.AssignmentIcon.V2 - MINOR ----

    Added:
        genres : Nri.Ui.Svg.V1.Svg
        genresCircled : Nri.Ui.Svg.V1.Svg


---- Nri.Ui.Menu.V4 - MINOR ----

    Added:
        captionedGroup :
            String.String
            -> String.String
            -> List.List (Nri.Ui.Menu.V4.Entry msg)
            -> Nri.Ui.Menu.V4.Entry msg
        groupCaptionCss : List.List Css.Style -> Nri.Ui.Menu.V4.Attribute msg
        groupTitleCss : List.List Css.Style -> Nri.Ui.Menu.V4.Attribute msg
        menuCss : List.List Css.Style -> Nri.Ui.Menu.V4.Attribute msg

Releasing

After this PR merges, and you've pulled down latest master, finish following the publishing process.


@erik-nri erik-nri changed the title bump version bump version (new Menu function and css helpers, new genres icons Mar 20, 2024
@erik-nri erik-nri marked this pull request as ready for review March 20, 2024 22:48
@erik-nri erik-nri requested a review from caseyWebb March 21, 2024 01:52
Copy link
Member

@caseyWebb caseyWebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@NoRedInkBot r+

nora-dingbot bot added a commit that referenced this pull request Mar 21, 2024
1660: bump version (new Menu function and css helpers, new genres icons r=caseyWebb a=erik-nri

# 🏷️ Bump for version `28.3.0`

## What changes does this release include?

- #1657
- #1658

## How has the API changed?

Please paste the output of `elm diff` run on latest master in the code block:

```
This is a MINOR change.

---- Nri.Ui.AssignmentIcon.V2 - MINOR ----

    Added:
        genres : Nri.Ui.Svg.V1.Svg
        genresCircled : Nri.Ui.Svg.V1.Svg


---- Nri.Ui.Menu.V4 - MINOR ----

    Added:
        captionedGroup :
            String.String
            -> String.String
            -> List.List (Nri.Ui.Menu.V4.Entry msg)
            -> Nri.Ui.Menu.V4.Entry msg
        groupCaptionCss : List.List Css.Style -> Nri.Ui.Menu.V4.Attribute msg
        groupTitleCss : List.List Css.Style -> Nri.Ui.Menu.V4.Attribute msg
        menuCss : List.List Css.Style -> Nri.Ui.Menu.V4.Attribute msg

```

## Releasing

After this PR merges, and you've pulled down latest master, finish following the [publishing process](https://github.com/NoRedInk/noredink-ui/blob/master/README.md#publishing-a-new-version).

---

Co-authored-by: Erik Feeley <erik@noredink.com>
@caseyWebb
Copy link
Member

wait this is nri-ui

@caseyWebb caseyWebb merged commit d2da6f1 into master Mar 21, 2024
8 of 9 checks passed
@caseyWebb caseyWebb deleted the bump-28.3.0 branch March 21, 2024 13:10
@nora-dingbot
Copy link
Contributor

nora-dingbot bot commented Mar 21, 2024

This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants