Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of generic OAuth logic made by using
system
operator.Generic OAuth logic is ~150 lines long in
Sources/RxOAuth/RxOAuth.swift
There are also unit tests included, and it seems to work ok :)
shouldRefreshNow
.tokenInvalidated
, oauth token is refreshed and original request is retried exactly once with the new token..tokenInvalidated
(usually 401). This is to guard against buggy server implementations (been there, done that :) In case any other call returns.tokenInvalidated
(usually 401), it will only initiate token refresh logic.There are 2 ways how one could use this.
OAuth.feedback
provides feedback loops for that external state storage.OAuthExecutor.state
. E.g. In case of logout, OAuthExecutor.state would return.tokenInvalidated
. This isOAuth.system
interface.This is the first version to try out the concept. Doesn't look too bad :) Maybe it can be simplified more.