GitHubSearch example issue during lose of internet connection #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kzaher Excellent library !!!. I'm been reading a lot to be able to understand properly part of the stateful design of the library and it's real power.
During the search in the GithubPaginatedSearch if you start to make a search and then you disconnect your wifi then the system is going to retry every 0.1 seconds mainly because this line:
The only problem with that is that never is emitted the
Observable<Error>
to theState
to properly update the UI bindings (thestatus
label ). So pretty much if we change this behavior to after some attempts emit theObservable<Error>
the UI can be updated and we can keep the consistency of keep trying make the request consistently.I have to say that this example is taken from the excellent RxSwift book. I think this is one the best uses I saw for the
flatMapWithIndex
operator.