GitHubSearch example issue during lose of internet connection

[Vkt0r]

@kzaher Excellent library !!!. I'm been reading a lot to be able to understand properly part of the stateful design of the library and it's real power.

During the search in the GithubPaginatedSearch if you start to make a search and then you disconnect your wifi then the system is going to retry every 0.1 seconds mainly because this line:

.retryWhen { $0.delay(1.0, scheduler: MainScheduler.instance) }

The only problem with that is that never is emitted the Observable<Error> to the State to properly update the UI bindings (the status label ). So pretty much if we change this behavior to after some attempts emit the Observable<Error> the UI can be updated and we can keep the consistency of keep trying make the request consistently.

.retryWhen { errorTrigger in
            return errorTrigger.flatMapWithIndex { (error, attempt) -> Observable<Int> in
                if attempt >= maxAttempts - 1 {
                    return Observable.error(error)
                }
                
                return Observable<Int>
                    .timer(Double(attempt + 1), scheduler: MainScheduler.instance).take(1)
            }

I have to say that this example is taken from the excellent RxSwift book. I think this is one the best uses I saw for the flatMapWithIndex operator.