chore: bump vendor to libwebp-1.3.1 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your PR, pls review the test issue and fix the version number check. BTW, memleak fixed maybe include already in the last 0.9.1 version #19, It's still very thanks for the PR. |
|
@NoXF I've fixed the failing test. Please run the workflow again. BTW, seems like the memory leak will be fixed in jaredforth/webp#28. |
okay, but In case of misunderstanding, use libwebp_sys::WebPPictureFree does not rely on libwebp@1.3.1, it has existed since the first commit, the memleak i mentioned above is libwebp's problem itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update libwebp to 1.3.1 (might solve #20)