fix LSP update logic #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- LSP update logic had couple of problems:
a) it prompted user for version update before verifying whether it's even needed;
b) if update failed or user opted out, then module returned undefined
instead of the existing binary path
Fixes NoahTheDuke#11
|
I don't have a ton of time for OS work, but this looks good to me, so let's merge and find out! |
|
After testing looks good to me. Maybe cut a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) it prompted user for version update before verifying whether it's even needed;
b) if update failed or user opted out, then module returned undefined instead of the existing binary path
Fixes #11
Note this change has not been tested!