Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate current_users method from activity_logging submodule #602

Closed
kirs opened this issue Jul 29, 2014 · 6 comments
Closed

Deprecate current_users method from activity_logging submodule #602

kirs opened this issue Jul 29, 2014 · 6 comments

Comments

@kirs
Copy link
Collaborator

kirs commented Jul 29, 2014

I thought that we could deprecate current_users method because it's up to developer to write such methods and we'd reduce amount of ORM-specific code that we need to support.

@kirs
Copy link
Collaborator Author

kirs commented Jul 29, 2014

This idea originally belongs to @juike.

@arnvald
Copy link
Collaborator

arnvald commented Jul 30, 2014

Good idea! 👍

kirs added a commit that referenced this issue Jul 31, 2014
kirs added a commit that referenced this issue Jul 31, 2014
arnvald added a commit that referenced this issue Aug 2, 2014
@arnvald
Copy link
Collaborator

arnvald commented Aug 2, 2014

Closed by #604

@arnvald arnvald closed this as completed Aug 2, 2014
@bodrovis
Copy link

@arnvald Will this method remain

?

@arnvald
Copy link
Collaborator

arnvald commented Feb 13, 2015

@bodrovis no, I'm going to remove it in 1.0 and just provide the code above as example implementation in wiki

@bodrovis
Copy link

@arnvald Okay, I was supposing that :) Then how can I access last_activity_at_attribute_name from my model? I am not sure, thought, that I need that at all - I can replace config.last_activity_at_attribute_name with the actual attibute's name. Thank you for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants