Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bundle extra dependencies #773

Closed
a14m opened this issue May 4, 2016 · 2 comments
Closed

Don't bundle extra dependencies #773

a14m opened this issue May 4, 2016 · 2 comments

Comments

@a14m
Copy link
Contributor

a14m commented May 4, 2016

In the gemfile (https://github.com/NoamB/sorcery/blob/master/sorcery.gemspec#L21-L22)
oauth and oauth2 (and they both have a lot of dependencies bundled with them) are bundled with every install although they are not needed all the time...

Can we remove these dependencies and mention bundling them in the readme if a user wanted to have the external modules supported ? or better, automatically appending them to the gemfile (if they are not there) when generating the submodule migration ?

if this is required, I can add a PR (on my free time) to address this
inspired by https://www.mikeperham.com/2016/02/09/kill-your-dependencies/

@arnvald
Copy link
Collaborator

arnvald commented May 15, 2016

Hey @mad-raz

I think it's a good idea. If you can submit a PR for that, it'd be great.

@a14m a14m mentioned this issue May 28, 2016
@Ch4s3
Copy link
Contributor

Ch4s3 commented May 28, 2016

This would be great for the next release @mad-raz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants