Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "add validator" #305

Merged
merged 4 commits into from
Nov 12, 2020
Merged

Refactor "add validator" #305

merged 4 commits into from
Nov 12, 2020

Conversation

BeroBurny
Copy link
Collaborator

closes #294
closes #295

@BeroBurny BeroBurny self-assigned this Nov 11, 2020
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #305 (803f990) into master (c58021a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   61.34%   61.34%           
=======================================
  Files          65       65           
  Lines         965      965           
  Branches      106      106           
=======================================
  Hits          592      592           
  Misses        349      349           
  Partials       24       24           
Flag Coverage Δ
unit 61.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c58021a...8951743. Read the comment docs.

Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BeroBurny BeroBurny merged commit e9fdfb7 into master Nov 12, 2020
@BeroBurny BeroBurny deleted the remove-generate-keystore branch November 12, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add validator] Import option picking Remove generate keys and deposit logic
2 participants