Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi client 👨‍🦯 #565

Merged
merged 36 commits into from
Jun 25, 2021
Merged

Multi client 👨‍🦯 #565

merged 36 commits into from
Jun 25, 2021

Conversation

BeroBurny
Copy link
Collaborator

@BeroBurny BeroBurny commented Jun 7, 2021

this is kinda big so submitted draft to check if I'm going in a good direction whit it

  • improve package.json scripts (now you can run all-important commands with yarn)
  • update beacon node versions (meanwhile some get newer versions)
  • implement nimbus beacon node (WIP)
    • implement tests
    • implement ETH2 client
      • think it is not working at 100%
    • implement nimbus to ChainGuardian
      • dev problem with CORS
  • implement prysom beacon node (WIP)
    • implement tests
    • implement ETH2 client
      • missing many endpoints (added TODO's for every of it)
    • implement nimbus to ChainGuardian

Closes #550
Closes #551

@BeroBurny BeroBurny added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Jun 7, 2021
@BeroBurny BeroBurny requested a review from mpetrunic June 7, 2021 12:59
@BeroBurny BeroBurny self-assigned this Jun 7, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jun 8, 2021

This pull request introduces 3 alerts when merging cb0eec2 into 1b6ed34 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

// eslint-disable-next-line @typescript-eslint/no-unused-vars
public getFork = async (stateId: "head"): Promise<Fork | null> => {
try {
const forkMock = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should at least load this from some config so that it depends on network

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #565 (d55c8d4) into develop (1b6ed34) will decrease coverage by 4.29%.
The diff coverage is 27.27%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #565      +/-   ##
===========================================
- Coverage    52.79%   48.50%   -4.30%     
===========================================
  Files           95      110      +15     
  Lines         1644     1977     +333     
  Branches       182      214      +32     
===========================================
+ Hits           868      959      +91     
- Misses         747      989     +242     
  Partials        29       29              
Flag Coverage Δ
unit 48.50% <27.27%> (-4.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/renderer/services/api/http/httpClient.ts 11.42% <0.00%> (-0.34%) ⬇️
src/renderer/services/eth2/client/defaults.ts 40.00% <ø> (ø)
...vices/eth2/client/eth2ApiClient/cgEth2BeaconApi.ts 31.25% <ø> (ø)
...eth2/client/eth2ApiClient/cgEth2BeaconBlocksApi.ts 13.33% <0.00%> (ø)
...s/eth2/client/eth2ApiClient/cgEth2BeaconPoolApi.ts 21.42% <ø> (ø)
.../eth2/client/eth2ApiClient/cgEth2BeaconStateApi.ts 8.82% <ø> (ø)
...services/eth2/client/eth2ApiClient/cgEth2Config.ts 16.66% <ø> (ø)
...vices/eth2/client/eth2ApiClient/cgEth2EventsApi.ts 16.12% <ø> (ø)
...ervices/eth2/client/eth2ApiClient/cgEth2NodeApi.ts 11.11% <ø> (ø)
...s/eth2/client/eth2ApiClient/cgEth2ValidatorApi.tsx 9.75% <ø> (+0.23%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b6ed34...d55c8d4. Read the comment docs.

@BeroBurny BeroBurny mentioned this pull request Jun 24, 2021
7 tasks
@BeroBurny BeroBurny marked this pull request as ready for review June 25, 2021 08:36
@BeroBurny BeroBurny requested a review from a team as a code owner June 25, 2021 08:36
@BeroBurny BeroBurny requested review from morrigan and removed request for a team June 25, 2021 08:36
@BeroBurny BeroBurny merged commit 38e82c0 into develop Jun 25, 2021
@BeroBurny BeroBurny deleted the beroburnt/multi-client branch June 25, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants