Fix/node name #139
Merged
Fix/node name #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 6, 2020 08:28
morrigan
reviewed
Apr 6, 2020
| @@ -103,9 +103,10 @@ export class NodeUptimeNotificationService { | |||
| logger.info(`Sending mail to: ${user.email} for node: ${node.id}::${node.address}`); | |||
| if (config.env != "dev") { | |||
| logger.info(`Going to send email to ${user.id}.`); | |||
| const nodeName = node.name ? node.name : ''; | |||
There was a problem hiding this comment.
Default on frontend is Node ${node.id} so we can use that here as well
morrigan
requested changes
Apr 6, 2020
morrigan
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check if node name is defined before proceeding to sending email notification.
Resolves #137 Check for node name before sending email