Fix/email notification #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmlinaric
force-pushed
the
fix/email-notification
branch
from
e863575
to
97cbf40
Compare
|
@nmlinaric the problem I've seen when testing is that node in frontend was still offline because there was no new uptime record where it says offline. So, I've handled that and to be able to do that I've added a separate property. Ideally, this should be refactored to handle cronjob separately from received offline uptime (processNodeUptime function) and by having multiple smaller functions. |
morrigan
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general idea is to assume that all nodes are not working, except if they reported as working in the last 16 minutes.
Also I suggest to change on daemon app interval for sending uptime to 15 min, like it is for balance and block.
Then if no record is inserted into the DB in the last 15 min, then the new SQL query is triggered because of the 16 min mark,
isWorking: falseis inserted into the DB and at the cronjob time mark a notification mail is going to be sent.