[WIP] Fix Command Queue Stack Error in PUBSUB mode #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NodeRedis/contributors I'd like to have someone look at this, since I'm not so certain if this is a good way to handle it. |
This was referenced Sep 19, 2015
|
I would say for the sake of 2.0.0 we should get this in, but make an issue for further investigation. I would even throw a "help wanted" tag on the issue to get some community feedback on a possible refactor. |
This is going to fix a couple of open tickets. I'm not really happy with the solution as is but at least the app does not crash anymore and it seems to work as it should. But there are likely still errors with the pubsub mode.
|
@BridgeAR when you have a moment, mind rebasing this with master; I want to see if the Windows failures stop cropping up. |
BridgeAR
changed the title
|
@bcoe I have to rework this again. I think I got a way to fix this more approriate, but I have to find the time to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to fix a couple of open tickets. I'm not really happy with the solution as is but at least the app does not crash anymore and it seems to work as it should. But there are likely still errors with the pubsub mode and this is probably not a good fix. It would be good if we'd find a better solution at some later point.
This superseds #685 (it somehow did not fix the issue in my tests?) and fixes #603 and #577